[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v4 12/48] virtio-pmem-pci: force virtio version 1
From: |
Michael S. Tsirkin |
Subject: |
[PULL v4 12/48] virtio-pmem-pci: force virtio version 1 |
Date: |
Tue, 29 Sep 2020 03:21:23 -0400 |
From: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Qemu fails with below error when trying to run with virtio pmem:
(qemu) qemu-system-x86_64: -device virtio-pmem-pci,memdev=mem1,id=nv1:
device is modern-only, use disable-legacy=on
This patch fixes this by forcing virtio 1 with virtio-pmem.
fixes: adf0748a49 ("virtio-pci: Proxy for virtio-pmem")
Signed-off-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
Message-Id: <20200925102251.7216-1-pankaj.gupta.linux@gmail.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio/virtio-pmem-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virtio-pmem-pci.c
index 21a457d151..2b2a0b1eae 100644
--- a/hw/virtio/virtio-pmem-pci.c
+++ b/hw/virtio/virtio-pmem-pci.c
@@ -22,6 +22,7 @@ static void virtio_pmem_pci_realize(VirtIOPCIProxy *vpci_dev,
Error **errp)
VirtIOPMEMPCI *pmem_pci = VIRTIO_PMEM_PCI(vpci_dev);
DeviceState *vdev = DEVICE(&pmem_pci->vdev);
+ virtio_pci_force_virtio_1(vpci_dev);
qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
}
--
MST
- [PULL v4 36/48] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus, (continued)
- [PULL v4 36/48] tests/acpi: add new unit test to test hotplug off/on feature on the root pci bus, Michael S. Tsirkin, 2020/09/29
- [PULL v4 38/48] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus, Michael S. Tsirkin, 2020/09/29
- [PULL v4 40/48] tests/acpi: list added acpi table binary file for pci bridge hotplug test, Michael S. Tsirkin, 2020/09/29
- [PULL v4 37/48] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off, Michael S. Tsirkin, 2020/09/29
- [PULL v4 41/48] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag, Michael S. Tsirkin, 2020/09/29
- [PULL v4 42/48] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag, Michael S. Tsirkin, 2020/09/29
- [PULL v4 44/48] piix4: don't reserve hw resources when hotplug is off globally, Michael S. Tsirkin, 2020/09/29
- [PULL v4 43/48] Add ACPI DSDT tables for q35 that are being updated by the next patch, Michael S. Tsirkin, 2020/09/29
- [PULL v4 46/48] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs, Michael S. Tsirkin, 2020/09/29
- [PULL v4 48/48] libvhost-user: return on error in vu_log_queue_fill(), Michael S. Tsirkin, 2020/09/29
- [PULL v4 12/48] virtio-pmem-pci: force virtio version 1,
Michael S. Tsirkin <=
- [PULL v4 01/48] linux headers: sync to 5.9-rc4, Michael S. Tsirkin, 2020/09/29
- [PULL v4 23/48] x86: cpuhp: refuse cpu hot-unplug request earlier if not supported, Michael S. Tsirkin, 2020/09/29
- [PULL v4 30/48] tests: acpi: update acpi blobs with new AML, Michael S. Tsirkin, 2020/09/29
- [PULL v4 20/48] virtio: update MemoryRegionCaches when guest set bad features, Michael S. Tsirkin, 2020/09/29
- [PULL v4 02/48] vhost: switch to use IOTLB v2 format, Michael S. Tsirkin, 2020/09/29
- [PULL v4 47/48] libvhost-user: return early on virtqueue errors, Michael S. Tsirkin, 2020/09/29
- [PULL v4 45/48] tests/acpi: update golden master DSDT binary table blobs for q35, Michael S. Tsirkin, 2020/09/29
- Re: [PULL v4 00/48] virtio,pc,acpi: fixes, tests, no-reply, 2020/09/29
- Re: [PULL v4 00/48] virtio,pc,acpi: fixes, tests, no-reply, 2020/09/29
- Re: [PULL v4 00/48] virtio,pc,acpi: fixes, tests, Peter Maydell, 2020/09/29