[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort |
|
Date: |
Tue, 29 Sep 2020 00:13:57 -0400 |
On Mon, Sep 28, 2020 at 10:34:42AM -0400, John Snow wrote:
> On 9/28/20 8:13 AM, Markus Armbruster wrote:
> > PEP 8: "Surround top-level function and class definitions with two blank
> > lines."
> >
> > [...]
> >
> >
>
> Yep, but flake8 does not complain about the first definitions that occur
> below imports. Why not? I don't know.
>
> Regardless, I can change it and fold the changes in; they won't affect much
> here.
>
Well, on all of the cases here, it's not function or class definition
that follows, so that aspect of PEP 8 is not being violated.
- Cleber.
signature.asc
Description: PGP signature
- [PATCH v3 08/47] qapi: move generator entrypoint into module, (continued)
- [PATCH v3 08/47] qapi: move generator entrypoint into module, John Snow, 2020/09/24
- [PATCH v3 01/47] [DO-NOT-MERGE] docs: replace single backtick (`) with double-backtick (``), John Snow, 2020/09/24
- [PATCH v3 11/47] qapi: Remove wildcard includes, John Snow, 2020/09/24
- [PATCH v3 09/47] [DO-NOT-MERGE] docs: add scripts/qapi/main to python manual, John Snow, 2020/09/24
- [PATCH v3 12/47] qapi: enforce import order/styling with isort, John Snow, 2020/09/24
Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, Cleber Rosa, 2020/09/29
[PATCH v3 10/47] qapi: Prefer explicit relative imports, John Snow, 2020/09/24
[PATCH v3 13/47] qapi: delint using flake8, John Snow, 2020/09/24
[PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, John Snow, 2020/09/24
[PATCH v3 15/47] qapi/common.py: Remove python compatibility workaround, John Snow, 2020/09/24
[PATCH v3 20/47] qapi/common.py: add type hint annotations, John Snow, 2020/09/24