[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/15] block: simplify comment to BDRV_REQ_SERIALISING
From: |
Alberto Garcia |
Subject: |
Re: [PATCH v6 01/15] block: simplify comment to BDRV_REQ_SERIALISING |
Date: |
Mon, 28 Sep 2020 17:34:20 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 18 Sep 2020 08:19:37 PM CEST, Vladimir Sementsov-Ogievskiy wrote:
> 1. BDRV_REQ_NO_SERIALISING doesn't exist already, don't mention it.
>
> 2. We are going to add one more user of BDRV_REQ_SERIALISING, so
> comment about backup becomes a bit confusing here. The use case in
> backup is documented in block/backup.c, so let's just drop
> duplication here.
>
> 3. The fact that BDRV_REQ_SERIALISING is only for write requests is
> omitted. Add a note.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Berto
- [PATCH v6 00/15] preallocate filter, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 01/15] block: simplify comment to BDRV_REQ_SERIALISING, Vladimir Sementsov-Ogievskiy, 2020/09/18
- Re: [PATCH v6 01/15] block: simplify comment to BDRV_REQ_SERIALISING,
Alberto Garcia <=
- [PATCH v6 02/15] block/io.c: drop assertion on double waiting for request serialisation, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 03/15] block/io: split out bdrv_find_conflicting_request, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 05/15] block: bdrv_mark_request_serialising: split non-waiting function, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 04/15] block/io: bdrv_wait_serialising_requests_locked: drop extra bs arg, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 06/15] block: introduce BDRV_REQ_NO_WAIT flag, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 07/15] block: bdrv_check_perm(): process children anyway, Vladimir Sementsov-Ogievskiy, 2020/09/18
- [PATCH v6 09/15] qemu-io: add preallocate mode parameter for truncate command, Vladimir Sementsov-Ogievskiy, 2020/09/18