Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort

From:	John Snow
Subject:	Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort
Date:	Mon, 28 Sep 2020 10:34:42 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/28/20 8:13 AM, Markus Armbruster wrote:

PEP 8: "Surround top-level function and class definitions with two blank
lines."

[...]

Yep, but flake8 does not complain about the first definitions that occurbelow imports. Why not? I don't know.

Regardless, I can change it and fold the changes in; they won't affectmuch here.


--js

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 04/47] qapi: modify docstrings to be sphinx-compatible, (continued)
- [PATCH v3 08/47] qapi: move generator entrypoint into module, John Snow, 2020/09/24
- [PATCH v3 01/47] [DO-NOT-MERGE] docs: replace single backtick (`) with double-backtick (``), John Snow, 2020/09/24
  - Re: [PATCH v3 01/47] [DO-NOT-MERGE] docs: replace single backtick (`) with double-backtick (``), Cleber Rosa, 2020/09/28
- [PATCH v3 11/47] qapi: Remove wildcard includes, John Snow, 2020/09/24
- [PATCH v3 09/47] [DO-NOT-MERGE] docs: add scripts/qapi/main to python manual, John Snow, 2020/09/24
- [PATCH v3 12/47] qapi: enforce import order/styling with isort, John Snow, 2020/09/24
  - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, Markus Armbruster, 2020/09/25
    - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, John Snow, 2020/09/25
    - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, Markus Armbruster, 2020/09/28
    - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, John Snow <=
    - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, Cleber Rosa, 2020/09/29
  - Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort, Cleber Rosa, 2020/09/29
- [PATCH v3 10/47] qapi: Prefer explicit relative imports, John Snow, 2020/09/24
- [PATCH v3 13/47] qapi: delint using flake8, John Snow, 2020/09/24
- [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, John Snow, 2020/09/24
  - Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, Markus Armbruster, 2020/09/25
    - Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, John Snow, 2020/09/25
  - Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, Cleber Rosa, 2020/09/28
    - Re: [PATCH v3 05/47] qapi/doc.py: Change code templates from function to string, John Snow, 2020/09/29
- [PATCH v3 15/47] qapi/common.py: Remove python compatibility workaround, John Snow, 2020/09/24

Prev by Date: Re: [PATCH 2/3] nbd: Add new qemu:allocation-depth metacontext
Next by Date: Re: [PATCH 3/3] nbd: Add 'qemu-nbd -A' to expose allocation depth
Previous by thread: Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort
Next by thread: Re: [PATCH v3 12/47] qapi: enforce import order/styling with isort
Index(es):
- Date
- Thread