[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler |
Date: |
Mon, 28 Sep 2020 14:58:58 +0200 |
Since commit efc6c070aca ("configure: Add a test for the
minimum compiler version") the minimum compiler version
required for GCC is 4.8, which has the GCC BZ#36793 bug fixed.
We can safely remove the special case introduced in commit
a281ebc11a6 ("virtio: add missing mb() on notification").
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/qemu/atomic.h | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h
index c1d211a3519..8f4b3a80fbd 100644
--- a/include/qemu/atomic.h
+++ b/include/qemu/atomic.h
@@ -241,23 +241,6 @@
#else /* __ATOMIC_RELAXED */
-/*
- * We use GCC builtin if it's available, as that can use mfence on
- * 32-bit as well, e.g. if built with -march=pentium-m. However, on
- * i386 the spec is buggy, and the implementation followed it until
- * 4.3 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=36793).
- */
-#if defined(__i386__) || defined(__x86_64__)
-#if !QEMU_GNUC_PREREQ(4, 4)
-#if defined __x86_64__
-#define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; })
-#else
-#define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory");
(void)0; })
-#endif
-#endif
-#endif
-
-
#ifdef __alpha__
#define smp_read_barrier_depends() asm volatile("mb":::"memory")
#endif
--
2.26.2
- [PATCH 0/3] qemu/compiler: Remove unused special case code for GCC < 4.8, Philippe Mathieu-Daudé, 2020/09/28
- [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Philippe Mathieu-Daudé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Paolo Bonzini, 2020/09/28
[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler,
Philippe Mathieu-Daudé <=
[PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6, Philippe Mathieu-Daudé, 2020/09/28