[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_D
From: |
Christian Schoenebeck |
Subject: |
Re: [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG |
Date: |
Mon, 28 Sep 2020 14:11:04 +0200 |
On Montag, 28. September 2020 10:31:21 CEST Paolo Bonzini wrote:
> On 27/09/20 12:40, Christian Schoenebeck wrote:
> > For now this new environment variable QTEST_DEBUG will cause the
> > assembled qemu command line to be printed before running each test.
> >
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
> >
> > tests/qtest/qos-test.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
> > index 4b1a1922fc..571d1e140a 100644
> > --- a/tests/qtest/qos-test.c
> > +++ b/tests/qtest/qos-test.c
> > @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)
> >
> > static void restart_qemu_or_continue(char *path)
> > {
> >
> > + if (getenv("QTEST_DEBUG") != NULL) {
> > + printf("run QEMU with: '%s'\n", path);
> > + }
> >
> > /* compares the current command line with the
> >
> > * one previously executed: if they are the same,
> > * don't restart QEMU, if they differ, stop previous
>
> You can just use g_test_message for this and do it unconditionally.
I actually had to read the glib sources to understand how g_test_message()'s
output is turned on: by appending '--verbose' to the CL.
Okay then.
Best regards,
Christian Schoenebeck
- [PATCH 00/12] 9pfs: add tests using local fs driver, Christian Schoenebeck, 2020/09/27
- [PATCH 05/12] tests/qtest/qos-test: add QTEST_DUMP_ENV environment variable, Christian Schoenebeck, 2020/09/27
- [PATCH 12/12] tests/9pfs: add local Tmkdir test, Christian Schoenebeck, 2020/09/27
- [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG, Christian Schoenebeck, 2020/09/27
- [PATCH 07/12] test/9pfs: change export tag name to qtest-synth, Christian Schoenebeck, 2020/09/27
- [PATCH 04/12] tests/qtest/qos-test: new QTEST_DUMP_GRAPH environment variable, Christian Schoenebeck, 2020/09/27
- [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named(), Christian Schoenebeck, 2020/09/27
- [PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode, Christian Schoenebeck, 2020/09/27
- [PATCH 09/12] tests/9pfs: introduce local tests, Christian Schoenebeck, 2020/09/27
- [PATCH 03/12] tests/qtest/qos: add qos_dump_graph(), Christian Schoenebeck, 2020/09/27
- [PATCH 08/12] tests/9pfs: refactor test names and test devices, Christian Schoenebeck, 2020/09/27