Re: [PATCH 00/16] hw/block/nvme: zoned namespace command set

[Klaus Jensen]

On Sep 24 15:43, no-reply@patchew.org wrote:
> Patchew URL: 
> 20200924204516.1881843-1-its@irrelevant.dk/">https://patchew.org/QEMU/20200924204516.1881843-1-its@irrelevant.dk/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 20200924204516.1881843-1-its@irrelevant.dk
> Subject: [PATCH 00/16] hw/block/nvme: zoned namespace command set
> 
> 7/16 Checking commit ab4c119d9d68 (hw/block/nvme: add commands supported and 
> effects log page)
> ERROR: Macros with complex values should be enclosed in parenthesis
> #46: FILE: hw/block/nvme.c:131:
> +#define NVME_EFFECTS_NVM_INITIALIZER                   \
> +    [NVME_CMD_FLUSH]            = NVME_EFFECTS_CSUPP | \
> +                                  NVME_EFFECTS_LBCC,   \
> +    [NVME_CMD_WRITE]            = NVME_EFFECTS_CSUPP | \
> +                                  NVME_EFFECTS_LBCC,   \
> +    [NVME_CMD_READ]             = NVME_EFFECTS_CSUPP,  \
> +    [NVME_CMD_WRITE_ZEROES]     = NVME_EFFECTS_CSUPP | \
> +                                  NVME_EFFECTS_LBCC
> 

Pffft. If anyone has a better idea how to make this nice and not too
repetitive in the code, please let me know ;)

> 11/16 Checking commit 6343d89bf734 (hw/block/nvme: add the zone management 
> send command)
> WARNING: Block comments use a leading /* on a separate line
> #66: FILE: hw/block/nvme.c:1118:
> +    return __nvme_allocate(ns, slba, nlb, false /* deallocate */);
> 
> WARNING: Block comments use a leading /* on a separate line
> #77: FILE: hw/block/nvme.c:1129:
> +    return __nvme_allocate(ns, slba, nlb, true /* deallocate */);
> 
> total: 0 errors, 2 warnings, 704 lines checked
> 
> Patch 11/16 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.

I seem to remember that this has been up before, but doesnt look like a
fix for that has gone into checkpatch.pl.

signature.asc
Description: PGP signature