Re: [PATCH v4 0/2] qemu/atomic.h: rename atomic_ to qatomic_

[no-reply]

Patchew URL: 20200923151901.745277-1-philmd@redhat.com/">https://patchew.org/QEMU/20200923151901.745277-1-philmd@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200923151901.745277-1-philmd@redhat.com
Subject: [PATCH v4 0/2] qemu/atomic.h: rename atomic_ to qatomic_

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200923151901.745277-1-philmd@redhat.com -> 
patchew/20200923151901.745277-1-philmd@redhat.com
Switched to a new branch 'test'
1661a2c qemu/atomic.h: rename atomic_ to qatomic_
b27980b qemu/atomic: Update coding style to make checkpatch.pl happier

=== OUTPUT BEGIN ===
1/2 Checking commit b27980bf1db5 (qemu/atomic: Update coding style to make 
checkpatch.pl happier)
ERROR: Use of volatile is usually wrong, please add a comment
#23: FILE: include/qemu/atomic.h:328:
+#define atomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile *) (p))

ERROR: Use of volatile is usually wrong, please add a comment
#24: FILE: include/qemu/atomic.h:329:
+#define atomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile *) (p)) = (i))

total: 2 errors, 0 warnings, 50 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 1661a2c48e6c (qemu/atomic.h: rename atomic_ to qatomic_)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#2801: FILE: include/qemu/atomic.h:152:
+#define qatomic_rcu_read__nocheck(ptr, valptr)           \
+    __atomic_load(ptr, valptr, __ATOMIC_RELAXED);        \
     smp_read_barrier_depends();

ERROR: Use of volatile is usually wrong, please add a comment
#2946: FILE: include/qemu/atomic.h:333:
+#define qatomic_read__nocheck(p)   (*(__typeof__(*(p)) volatile *) (p))

ERROR: Use of volatile is usually wrong, please add a comment
#2947: FILE: include/qemu/atomic.h:334:
+#define qatomic_set__nocheck(p, i) ((*(__typeof__(*(p)) volatile *) (p)) = (i))

ERROR: memory barrier without comment
#3024: FILE: include/qemu/atomic.h:395:
+#define qatomic_xchg(ptr, i)    (smp_mb(), __sync_lock_test_and_set(ptr, i))

total: 4 errors, 0 warnings, 6269 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200923151901.745277-1-philmd@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200923151901.745277-1-philmd@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com