|
From: | John Snow |
Subject: | Re: [PATCH v2 24/38] qapi/gen.py: Fix edge-case of _is_user_module |
Date: | Wed, 23 Sep 2020 14:29:28 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 9/23/20 11:17 AM, Eduardo Habkost wrote:
This changes behavior if name=='', and I guess this is OK, but I'm not sure. I miss documentation on `visit_module()`, `visit_include()`, and `_is_user_module()`. I don't know what `name` means here, and what is a "user module".
Good spot, I missed that. I can probably do: bool(name and not name.startswith('./'))to convert explicitly the empty string to false. I will allow Markus the chance to explain the module stuff.
--js
[Prev in Thread] | Current Thread | [Next in Thread] |