Re: [PATCH 27/29] nbd: Deprecate nbd-server-add/remove

[Kevin Wolf]

Am 10.09.2020 um 17:34 hat Max Reitz geschrieben:
> On 07.09.20 20:20, Kevin Wolf wrote:
> > These QMP commands are replaced by block-export-add/del.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> >  qapi/block-export.json     | 11 +++++++++--
> >  docs/system/deprecated.rst |  8 ++++++++
> >  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> OK, but:
> 
> > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> > index 851dbdeb8a..9a2e083f00 100644
> > --- a/docs/system/deprecated.rst
> > +++ b/docs/system/deprecated.rst
> > @@ -303,6 +303,14 @@ chardev client socket with ``wait`` option (since 4.0)
> >  Character devices creating sockets in client mode should not specify
> >  the 'wait' field, which is only applicable to sockets in server mode
> >  
> > +``nbd-server-add`` and ``nbd-server-remove`` (since 5.2)
> > +''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> > +
> > +Use the more generic commands ``block-export-add`` and ``block-export-del``
> > +instead.
> > +
> > +Use argument value ``null`` instead.
> 
> I don’t understand this sentence.

Me neither, it's wrong. Looks like a copy from a few lines further up...
I'll just remove this sentence.

Kevin

signature.asc
Description: PGP signature