[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 17/25] qapi: Disable similarity checks in pylint entirely
|
From: |
John Snow |
|
Subject: |
[PATCH 17/25] qapi: Disable similarity checks in pylint entirely |
|
Date: |
Tue, 22 Sep 2020 18:44:53 -0400 |
The pylint similarity checks cannot distinguish parameter lists from
other code; with the QAPISchemaVisitor interface having long lists of
parameters, these similarity checks fire off in a way that's difficult
to disable in a targeted way without littering the code with pylint
pragmas.
There is a change request filed to be able to ignore parameter lists,
see: https://github.com/PyCQA/pylint/issues/3619
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/pylintrc | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index 5091a08f12..fb444e93bb 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -18,6 +18,7 @@ ignore-patterns=schema.py,
# --disable=W".
disable=fixme,
missing-docstring,
+ similarities, # See https://github.com/PyCQA/pylint/issues/3619
too-many-arguments,
too-many-branches,
too-many-statements,
--
2.26.2
- [PATCH 13/25] qapi/schema.py: Test type of self.ret_type instead of local temp, (continued)
- [PATCH 13/25] qapi/schema.py: Test type of self.ret_type instead of local temp, John Snow, 2020/09/22
- [PATCH 16/25] qapi/schema.py: enable checking, John Snow, 2020/09/22
- [PATCH 24/25] qapi/schema.py: Add module docstring, John Snow, 2020/09/22
- [PATCH 20/25] qapi/schema.py: Replace one-letter variable names, John Snow, 2020/09/22
- [PATCH 18/25] qapi/schema.py: Add pylint warning suppressions, John Snow, 2020/09/22
- [PATCH 25/25] qapi/schema.py: Use python3 style super(), John Snow, 2020/09/22
- [PATCH 23/25] qapi/schema.py: enable pylint checks, John Snow, 2020/09/22
- [PATCH 19/25] qapi/schema.py: Convert several methods to classmethods, John Snow, 2020/09/22
- [PATCH 15/25] qapi/schema.py: add type hint annotations, John Snow, 2020/09/22
- [PATCH 22/25] qapi/schema.py: Ignore unused argument for check(), John Snow, 2020/09/22
- [PATCH 17/25] qapi: Disable similarity checks in pylint entirely,
John Snow <=