[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/16] qapi/expr.py: Check for dict instead of OrderedDict
From: |
John Snow |
Subject: |
[PATCH 02/16] qapi/expr.py: Check for dict instead of OrderedDict |
Date: |
Tue, 22 Sep 2020 17:12:59 -0400 |
OrderedDict is a subtype of dict, so we can check for a more general form.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/expr.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index de659a54ad..1872a8a3cc 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -15,7 +15,7 @@
# See the COPYING file in the top-level directory.
import re
-from collections import OrderedDict
+
from .common import c_name
from .error import QAPISemError
@@ -123,7 +123,7 @@ def check_if_str(ifcond):
def normalize_members(members):
- if isinstance(members, OrderedDict):
+ if isinstance(members, dict):
for key, arg in members.items():
if isinstance(arg, dict):
continue
@@ -154,7 +154,7 @@ def check_type(value, info, source,
if not allow_dict:
raise QAPISemError(info, "%s should be a type name" % source)
- if not isinstance(value, OrderedDict):
+ if not isinstance(value, dict):
raise QAPISemError(info,
"%s should be an object or type name" % source)
--
2.26.2
- Re: [PATCH 04/16] qapi/expr.py: Add assertion for union type 'check_dict', (continued)
Re: [PATCH 04/16] qapi/expr.py: Add assertion for union type 'check_dict', Cleber Rosa, 2020/09/24
[PATCH 03/16] qapi/expr.py: constrain incoming expression types, John Snow, 2020/09/22
Re: [PATCH 03/16] qapi/expr.py: constrain incoming expression types, Cleber Rosa, 2020/09/24
[PATCH 02/16] qapi/expr.py: Check for dict instead of OrderedDict,
John Snow <=
[PATCH 05/16] qapi/expr.py: move string check upwards in check_type, John Snow, 2020/09/22
[PATCH 06/16] qapi/expr.py: Check type of 'data' member, John Snow, 2020/09/22