Re: [PATCH 7/7] configure: Bump the minimum required Python version to 3.6

[John Snow]

On 9/21/20 1:43 PM, Thomas Huth wrote:
> All our supported build platforms have Python 3.6 or newer nowadays,
> and there are some useful features in Python 3.6 which are not available
> in 3.5 yet, so let's bump the minimum Python version to 3.6 now.

Just to add in case anyone wonders: This isn't incrementalism for 
incrementalism's sake, but the type hint annotations added in Python 3.6 
allow us to statically type the QAPI parser.

We are already using (and enforcing) these annotations in iotests.py, 
and I believe adding this to QAPI will be of high value going forward.

> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   configure | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 7564479008..a3a643168e 100755
> --- a/configure
> +++ b/configure
> @@ -1965,8 +1965,8 @@ fi
>   
>   # Note that if the Python conditional here evaluates True we will exit
>   # with status 1 which is a shell 'false' value.
> -if ! $python -c 'import sys; sys.exit(sys.version_info < (3,5))'; then
> -  error_exit "Cannot use '$python', Python >= 3.5 is required." \
> +if ! $python -c 'import sys; sys.exit(sys.version_info < (3,6))'; then
> +  error_exit "Cannot use '$python', Python >= 3.6 is required." \
>         "Use --python=/path/to/python to specify a supported Python."
>   fi
>   

Do we need to bump the minimum version in the Sphinx conf, too?

There's also a minimum version check in iotests.py that is now 
*possibly* redundant, but it does no harm.

Regardless, none of those things cause any harm:

Reviewed-by: John Snow <jsnow@redhat.com>