Re: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

[Laurent Vivier]

On 20/09/2020 20:03, no-reply@patchew.org wrote:
> Patchew URL: 
> 20200920162434.868041-1-lvivier@redhat.com/">https://patchew.org/QEMU/20200920162434.868041-1-lvivier@redhat.com/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Type: series
> Message-id: 20200920162434.868041-1-lvivier@redhat.com
> Subject: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
>  * [new tag]         patchew/20200920175825.417680-1-f4bug@amsat.org -> 
> patchew/20200920175825.417680-1-f4bug@amsat.org
>  * [new tag]         patchew/84f1c61a-8399-c75e-96c2-febfc2dd5fab@t-online.de 
> -> patchew/84f1c61a-8399-c75e-96c2-febfc2dd5fab@t-online.de
> Switched to a new branch 'test'
> 08d1002 vhost-vdpa: add trace-events
> 7ac6b11 util/hexdump: introduce qemu_hexdump_line()
> 
> === OUTPUT BEGIN ===
> 1/2 Checking commit 7ac6b1191959 (util/hexdump: introduce qemu_hexdump_line())
> 2/2 Checking commit 08d100254c8b (vhost-vdpa: add trace-events)
> ERROR: Hex numbers must be prefixed with '0x'
> #29: FILE: hw/virtio/trace-events:32:
> +vhost_vdpa_set_mem_table(void *dev, uint32_t nregions, uint32_t padding) 
> "dev: %p nregions: %"PRIu32" padding: %"PRIx32
> 
> ERROR: code indent should never use tabs
> #126: FILE: hw/virtio/vhost-vdpa.c:275:
> +^Ifor (i = 0; i < mem->nregions; i++) {$
> 
> ERROR: code indent should never use tabs
> #194: FILE: hw/virtio/vhost-vdpa.c:355:
> +^Iqemu_hexdump_line(line, b, config, len, false);$
> 
> ERROR: code indent should never use tabs
> #195: FILE: hw/virtio/vhost-vdpa.c:356:
> +^Itrace_vhost_vdpa_dump_config(dev, line);$
> 
> ERROR: code indent should never use tabs
> #216: FILE: hw/virtio/vhost-vdpa.c:377:
> +^Ivhost_vdpa_dump_config(dev, data, size);$
> 
> ERROR: code indent should never use tabs
> #235: FILE: hw/virtio/vhost-vdpa.c:403:
> +^Ivhost_vdpa_dump_config(dev, config, config_len);$
> 
> WARNING: line over 80 characters
> #251: FILE: hw/virtio/vhost-vdpa.c:433:
> +    trace_vhost_vdpa_set_log_base(dev, base, log->size, log->refcnt, 
> log->fd, log->log);
> 
> total: 6 errors, 1 warnings, 291 lines checked
> 
> Patch 2/2 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> === OUTPUT END ===
> 
>

I'm going to resend the series with the problems reported by checkpatch
fixed.

Thanks,
Laurent