Re: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

[no-reply]

Patchew URL: 
cover.1600556526.git.maciej.szmigiero@oracle.com/">https://patchew.org/QEMU/cover.1600556526.git.maciej.szmigiero@oracle.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1600556526.git.maciej.szmigiero@oracle.com
Subject: [PATCH 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon)

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
180104d Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)
cb9f9d7 Add Hyper-V Dynamic Memory Protocol definitions
3f22e8f haprot: add a device for memory hot-add protocols

=== OUTPUT BEGIN ===
1/3 Checking commit 3f22e8fb4473 (haprot: add a device for memory hot-add 
protocols)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#109: 
new file mode 100644

WARNING: line over 80 characters
#212: FILE: hw/mem/haprot.c:99:
+                   "Node property value %"PRIu32" exceeds the number of numa 
nodes %d",

total: 0 errors, 2 warnings, 404 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit cb9f9d7b2fb4 (Add Hyper-V Dynamic Memory Protocol 
definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

WARNING: line over 80 characters
#52: FILE: include/hw/hyperv/dynmem-proto.h:33:
+#define DYNMEM_MAKE_VERSION(Major, Minor) ((uint32_t)(((Major) << 16) | 
(Minor)))

ERROR: space prohibited after that '&' (ctx:WxW)
#54: FILE: include/hw/hyperv/dynmem-proto.h:35:
+#define DYNMEM_MINOR_VERSION(Version) ((uint32_t)(Version) & 0xff)
                                                            ^

total: 1 errors, 2 warnings, 425 lines checked

Patch 2/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/3 Checking commit 180104d55786 (Add a Hyper-V Dynamic Memory Protocol driver 
(hv-balloon))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#188: 
new file mode 100644

WARNING: line over 80 characters
#248: FILE: hw/hyperv/hv-balloon.c:56:
+#define HV_BALLOON_HA_CHUNK_PAGES (HV_BALLOON_HA_CHUNK_SIZE / 
HV_BALLOON_PAGE_SIZE)

WARNING: line over 80 characters
#1236: FILE: hw/hyperv/hv-balloon.c:1044:
+                                  (1 << 
balloon->caps.cap_bits.hot_add_alignment)

WARNING: line over 80 characters
#1618: FILE: hw/hyperv/hv-balloon.c:1426:
+            warn_report("guest reported removed page backed by unsupported 
page size %zu",

WARNING: line over 80 characters
#1692: FILE: hw/hyperv/hv-balloon.c:1500:
+                warn_report("guest reported removed page %"PRIu64" not found 
in RAM",

ERROR: line over 90 characters
#1700: FILE: hw/hyperv/hv-balloon.c:1508:
+                warn_report("guest reported removed page %"PRIu64" in a 
section smaller than page size",

ERROR: line over 90 characters
#1710: FILE: hw/hyperv/hv-balloon.c:1518:
+                warn_report("guest reported removed page %"PRIu64" in a 
section that is not an ordinary RAM",

ERROR: line over 90 characters
#1749: FILE: hw/hyperv/hv-balloon.c:1557:
+        warn_report("guest reported more pages removed than currently pending 
(%"PRIu64" vs %"PRIu64")",

WARNING: line over 80 characters
#1863: FILE: hw/hyperv/hv-balloon.c:1671:
+    
qapi_event_send_hv_balloon_status_report((uint64_t)msgStatus->num_committed *

ERROR: line over 90 characters
#1918: FILE: hw/hyperv/hv-balloon.c:1726:
+            warn_report("DM_HOT_ADD_RESPONSE page count higher than requested 
(%"PRIu32" vs %"PRIu64")",

total: 4 errors, 6 warnings, 2369 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
cover.1600556526.git.maciej.szmigiero@oracle.com/testing.checkpatch/?type=message">http://patchew.org/logs/cover.1600556526.git.maciej.szmigiero@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com