[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 23/57] hw/char/serial: Remove old DEBUG_SERIAL commented code
From: |
Paolo Bonzini |
Subject: |
[PULL 23/57] hw/char/serial: Remove old DEBUG_SERIAL commented code |
Date: |
Sat, 19 Sep 2020 11:58:42 -0400 |
From: Philippe Mathieu-Daudé <f4bug@amsat.org>
All useful DPRINTF() calls have been converted to trace
events. Remove a pointless one in the IOEventHandler,
and drop the DEBUG_SERIAL ifdef'ry.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200907015535.827885-4-f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/char/serial.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/hw/char/serial.c b/hw/char/serial.c
index e8029f840a..26f7fa8a21 100644
--- a/hw/char/serial.c
+++ b/hw/char/serial.c
@@ -36,8 +36,6 @@
#include "trace.h"
#include "hw/qdev-properties.h"
-//#define DEBUG_SERIAL
-
#define UART_LCR_DLAB 0x80 /* Divisor latch access bit */
#define UART_IER_MSI 0x08 /* Enable Modem status interrupt */
@@ -102,14 +100,6 @@
#define MAX_XMIT_RETRY 4
-#ifdef DEBUG_SERIAL
-#define DPRINTF(fmt, ...) \
-do { fprintf(stderr, "serial: " fmt , ## __VA_ARGS__); } while (0)
-#else
-#define DPRINTF(fmt, ...) \
-do {} while (0)
-#endif
-
static void serial_receive1(void *opaque, const uint8_t *buf, int size);
static void serial_xmit(SerialState *s);
@@ -636,7 +626,6 @@ static void serial_receive1(void *opaque, const uint8_t
*buf, int size)
static void serial_event(void *opaque, QEMUChrEvent event)
{
SerialState *s = opaque;
- DPRINTF("event %x\n", event);
if (event == CHR_EVENT_BREAK)
serial_receive_break(s);
}
--
2.26.2
- [PULL 03/57] meson: clean up build_by_default, (continued)
- [PULL 03/57] meson: clean up build_by_default, Paolo Bonzini, 2020/09/19
- [PULL 06/57] meson: error out if qemu_suffix starts with /, Paolo Bonzini, 2020/09/19
- [PULL 05/57] meson: fix MSI rule, Paolo Bonzini, 2020/09/19
- [PULL 08/57] configure: Do not intent to build WHPX on 32-bit host, Paolo Bonzini, 2020/09/19
- [PULL 09/57] MAINTAINERS: add Paolo Bonzini as RCU maintainer, Paolo Bonzini, 2020/09/19
- [PULL 16/57] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text, Paolo Bonzini, 2020/09/19
- [PULL 12/57] vhost-scsi: support inflight io track, Paolo Bonzini, 2020/09/19
- [PULL 10/57] target/i386: support KVM_FEATURE_ASYNC_PF_INT, Paolo Bonzini, 2020/09/19
- [PULL 11/57] memory: Convert IOMMUMemoryRegionClass doc comment to kernel-doc, Paolo Bonzini, 2020/09/19
- [PULL 17/57] numa: remove fixup numa_state->num_nodes to MAX_NODES, Paolo Bonzini, 2020/09/19
- [PULL 23/57] hw/char/serial: Remove old DEBUG_SERIAL commented code,
Paolo Bonzini <=
- [PULL 24/57] hw/char/serial: Rename I/O read/write trace events, Paolo Bonzini, 2020/09/19
- [PULL 28/57] hw: megasas: return -1 when 'megasas_map_sgl' fails, Paolo Bonzini, 2020/09/19
- [PULL 19/57] hw/char/serial: Remove TYPE_SERIAL_IO, Paolo Bonzini, 2020/09/19
- [PULL 14/57] acpi: i386: Move VMBus DSDT entry to SB, Paolo Bonzini, 2020/09/19
- [PULL 13/57] Simplify the .gitignore file, Paolo Bonzini, 2020/09/19
- [PULL 15/57] numa: drop support for '-numa node' (without memory specified), Paolo Bonzini, 2020/09/19
- [PULL 26/57] hw/char/serial-{isa, pci}: Alias QDEV properties from generic serial object, Paolo Bonzini, 2020/09/19
- [PULL 29/57] hw: megasas: consider 'iov_count=0' is an error in megasas_map_sgl, Paolo Bonzini, 2020/09/19
- [PULL 31/57] meson: move libudev test, Paolo Bonzini, 2020/09/19
- [PULL 45/57] oslib-posix: relocate path to /var, Paolo Bonzini, 2020/09/19