qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] checkpatch: avoid error on cover letter files


From: Stefano Garzarella
Subject: Re: [PATCH] checkpatch: avoid error on cover letter files
Date: Fri, 18 Sep 2020 09:05:24 +0200

On Thu, Sep 17, 2020 at 07:44:21PM +0200, Philippe Mathieu-Daudé wrote:
> On 9/17/20 7:02 PM, Stefano Garzarella wrote:
> > Running checkpatch on a directory that contains a cover letter reports
> > this error:
> > 
> >     Checking /tmp/tmpbnngauy3/0000-cover-letter.patch...
> >     ERROR: Does not appear to be a unified-diff format patch
> > 
> >     total: 1 errors, 0 warnings, 0 lines checked
> > 
> > Let's skip cover letter as it is already done in the Linux kernel.
> 
> .. "commits 06330fc40e3f ("checkpatch: avoid NOT_UNIFIED_DIFF errors
>  on cover-letter.patch files") and a08ffbef4ab7 ("checkpatch: fix
> ignoring cover-letter logic")."
> 
> Maybe complete with that ^^^ ?

Yes, it's better ;-)

Should I send a v2 or can be updated when queueing?

> 
> Regardless:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks!

Stefano




reply via email to

[Prev in Thread] Current Thread [Next in Thread]