[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_me
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign |
|
Date: |
Thu, 17 Sep 2020 13:34:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/17/20 11:43 AM, Eduardo Habkost wrote:
> On Tue, Sep 15, 2020 at 05:46:33PM -0700, Richard Henderson wrote:
>> We do not need or want to be allocating page sized quanta.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Would it be safe to keep patches 2-6 applied in case this one
> gets dropped or reverted for any reason?
Yes.
Only objects using QEMU_ALIGNED() should have an __alignof__ larger than
qemu_max_align_t.
Therefore, I believe that the CPUArchState objects to be the only ones that
will go through qemu_memalign. So we won't end up with all QOM objects being
page allocated on Windows.
r~
- [PATCH v2 0/6] qom: Allow object to be aligned, Richard Henderson, 2020/09/15
- [PATCH v2 1/6] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign, Richard Henderson, 2020/09/15
- [PATCH v2 3/6] target/arm: Set instance_align on CPUARM TypeInfo, Richard Henderson, 2020/09/15
- [PATCH v2 2/6] qom: Allow objects to be allocated with increased alignment, Richard Henderson, 2020/09/15
- [PATCH v2 4/6] target/ppc: Set instance_align on PowerPCCPU TypeInfo, Richard Henderson, 2020/09/15
- [PATCH v2 5/6] target/riscv: Set instance_align on RISCVCPU TypeInfo, Richard Henderson, 2020/09/15
- [PATCH v2 6/6] target/s390x: Set instance_align on S390CPU TypeInfo, Richard Henderson, 2020/09/15
- Re: [PATCH v2 0/6] qom: Allow object to be aligned, Eduardo Habkost, 2020/09/18