Re: [PATCH V3 05/10] util/: fix some comment spelling errors

[Laurent Vivier]

Le 17/09/2020 à 09:50, zhaolichang a écrit :
> I found that there are many spelling errors in the comments of qemu,
> so I used the spellcheck tool to check the spelling errors
> and finally found some spelling errors in the util folder.
> 
> Signed-off-by: zhaolichang <zhaolichang@huawei.com>
> Reviewed-by: Alex Bennee <alex.bennee@linaro.org>
> ---
>  util/osdep.c             | 2 +-
>  util/qemu-progress.c     | 2 +-
>  util/qemu-sockets.c      | 2 +-
>  util/qemu-thread-win32.c | 2 +-
>  util/qht.c               | 2 +-
>  util/trace-events        | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/util/osdep.c b/util/osdep.c
> index 4829c07ff6..e50dc2214e 100644
> --- a/util/osdep.c
> +++ b/util/osdep.c
> @@ -392,7 +392,7 @@ int qemu_unlink(const char *name)
>   * Set errno if fewer than `count' bytes are written.
>   *
>   * This function don't work with non-blocking fd's.
> - * Any of the possibilities with non-bloking fd's is bad:
> + * Any of the possibilities with non-blocking fd's is bad:
>   *   - return a short write (then name is wrong)
>   *   - busy wait adding (errno == EAGAIN) to the loop
>   */
> diff --git a/util/qemu-progress.c b/util/qemu-progress.c
> index 3c2223c1a2..20d51f8c12 100644
> --- a/util/qemu-progress.c
> +++ b/util/qemu-progress.c
> @@ -131,7 +131,7 @@ void qemu_progress_end(void)
>  /*
>   * Report progress.
>   * @delta is how much progress we made.
> - * If @max is zero, @delta is an absolut value of the total job done.
> + * If @max is zero, @delta is an absolute value of the total job done.
>   * Else, @delta is a progress delta since the last call, as a fraction
>   * of @max.  I.e. the delta is @delta * @max / 100. This allows
>   * relative accounting of functions which may be a different fraction of
> diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
> index b37d288866..99ce2fd5e6 100644
> --- a/util/qemu-sockets.c
> +++ b/util/qemu-sockets.c
> @@ -416,7 +416,7 @@ static struct addrinfo 
> *inet_parse_connect_saddr(InetSocketAddress *saddr,
>  
>      /* At least FreeBSD and OS-X 10.6 declare AI_V4MAPPED but
>       * then don't implement it in their getaddrinfo(). Detect
> -     * this and retry without the flag since that's preferrable
> +     * this and retry without the flag since that's preferable
>       * to a fatal error
>       */
>      if (rc == EAI_BADFLAGS &&
> diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
> index 56a83333da..d207b0cb58 100644
> --- a/util/qemu-thread-win32.c
> +++ b/util/qemu-thread-win32.c
> @@ -289,7 +289,7 @@ void qemu_event_wait(QemuEvent *ev)
>              ResetEvent(ev->event);
>  
>              /* Tell qemu_event_set that there are waiters.  No need to retry
> -             * because there cannot be a concurent busy->free transition.
> +             * because there cannot be a concurrent busy->free transition.
>               * After the CAS, the event will be either set or busy.
>               */
>              if (atomic_cmpxchg(&ev->value, EV_FREE, EV_BUSY) == EV_SET) {
> diff --git a/util/qht.c b/util/qht.c
> index 67e5d5b916..b2e020c398 100644
> --- a/util/qht.c
> +++ b/util/qht.c
> @@ -49,7 +49,7 @@
>   * it anymore.
>   *
>   * Writers check for concurrent resizes by comparing ht->map before and after
> - * acquiring their bucket lock. If they don't match, a resize has occured
> + * acquiring their bucket lock. If they don't match, a resize has occurred
>   * while the bucket spinlock was being acquired.
>   *
>   * Related Work:
> diff --git a/util/trace-events b/util/trace-events
> index 4e894aa9c3..24c31803b0 100644
> --- a/util/trace-events
> +++ b/util/trace-events
> @@ -28,7 +28,7 @@ qemu_file_monitor_add_watch(void *mon, const char *dirpath, 
> const char *filename
>  qemu_file_monitor_remove_watch(void *mon, const char *dirpath, int64_t id) 
> "File monitor %p remove watch dir='%s' id=%" PRId64
>  qemu_file_monitor_new(void *mon, int fd) "File monitor %p created fd=%d"
>  qemu_file_monitor_enable_watch(void *mon, const char *dirpath, int id) "File 
> monitor %p enable watch dir='%s' id=%u"
> -qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) "Fle 
> monitor %p disable watch dir='%s' id=%u"
> +qemu_file_monitor_disable_watch(void *mon, const char *dirpath, int id) 
> "File monitor %p disable watch dir='%s' id=%u"
>  qemu_file_monitor_event(void *mon, const char *dirpath, const char 
> *filename, int mask, unsigned int id) "File monitor %p event dir='%s' 
> file='%s' mask=0x%x id=%u"
>  qemu_file_monitor_dispatch(void *mon, const char *dirpath, const char 
> *filename, int ev, void *cb, void *opaque, int64_t id) "File monitor %p 
> dispatch dir='%s' file='%s' ev=%d cb=%p opaque=%p id=%" PRId64
>  
> 

Applied to my trivial-patches branch.

Thanks,
Laurent