[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/37] qapi/common.py: split build_params into new file
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 15/37] qapi/common.py: split build_params into new file |
|
Date: |
Thu, 17 Sep 2020 16:42:50 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Including it in common.py creates a circular import dependency, because
> schema relies on common.py. To type build_params properly, it needs to
> be moved outside of the chain.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qapi/commands.py | 2 +-
> scripts/qapi/common.py | 23 -----------------------
> scripts/qapi/events.py | 2 +-
> scripts/qapi/params.py | 40 ++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 42 insertions(+), 25 deletions(-)
> create mode 100644 scripts/qapi/params.py
Ugh.
Would moving it gen.py work?
- Re: [PATCH 14/37] qapi/common.py: Move comments into docstrings, (continued)
[PATCH 13/37] qapi/common.py: add notational type hints, John Snow, 2020/09/15
[PATCH 15/37] qapi/common.py: split build_params into new file, John Snow, 2020/09/15
- Re: [PATCH 15/37] qapi/common.py: split build_params into new file,
Markus Armbruster <=
[PATCH 24/37] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/09/15
[PATCH 21/37] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/15
[PATCH 16/37] qapi: establish mypy type-checking baseline, John Snow, 2020/09/15