[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH v2 04/10] disas: Clean up CPUDebug initialization |
|
Date: |
Thu, 17 Sep 2020 16:39:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 15/09/2020 01.02, Richard Henderson wrote:
> Rename several functions, dropping "generic" and making "host"
> vs "target" clearer. Make a bunch of functions static that are
> not used outside this file. Replace INIT_DISASSEMBLE_INFO with
> a trio of functions.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/disas/dis-asm.h | 60 --------
> disas.c | 326 ++++++++++++++++++----------------------
> 2 files changed, 148 insertions(+), 238 deletions(-)
I only did a quick review... looks fine to me, so:
Acked-by: Thomas Huth <thuth@redhat.com>
Re: [PATCH v2 01/10] capstone: Convert Makefile bits to meson bits, Thomas Huth, 2020/09/15
[PATCH v2 02/10] capstone: Update to upstream "next" branch, Richard Henderson, 2020/09/14
[PATCH v2 03/10] disas: Move host asm annotations to tb_gen_code, Richard Henderson, 2020/09/14
[PATCH v2 04/10] disas: Clean up CPUDebug initialization, Richard Henderson, 2020/09/14
[PATCH v2 05/10] disas: Use qemu/bswap.h for bfd endian loads, Richard Henderson, 2020/09/14
[PATCH v2 06/10] disas: Cleanup plugin_disas, Richard Henderson, 2020/09/14
[PATCH v2 07/10] disas: Configure capstone for aarch64 host without libvixl, Richard Henderson, 2020/09/14
[PATCH v2 08/10] disas: Split out capstone code to disas/capstone.c, Richard Henderson, 2020/09/14
[PATCH v2 10/10] disas/capstone: Add skipdata hook for s390x, Richard Henderson, 2020/09/14