[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qom: Correct error values in two contracts
From: |
Greg Kurz |
Subject: |
Re: [PATCH 2/2] qom: Correct error values in two contracts |
Date: |
Thu, 17 Sep 2020 15:31:21 +0200 |
On Thu, 17 Sep 2020 14:55:40 +0200
Markus Armbruster <armbru@redhat.com> wrote:
> object_property_get_bool()'s contract claims it returns NULL on error.
> Pasto; it returns false.
>
> object_property_get_int()'s contract claims it returns "negative". It
> actually returns -1. All the other object_property_get_FOO()
> contracts specify the exact error value, so do the same here.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> include/qom/object.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index f75547a3fe..d0a3332c1f 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1624,7 +1624,7 @@ bool object_property_set_bool(Object *obj, const char
> *name,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to a boolean, or NULL if
> + * Returns: the value of the property, converted to a boolean, or false if
> * an error occurs (including when the property value is not a bool).
> */
> bool object_property_get_bool(Object *obj, const char *name,
> @@ -1649,7 +1649,7 @@ bool object_property_set_int(Object *obj, const char
> *name,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to an integer, or negative
> if
> + * Returns: the value of the property, converted to an integer, or -1 if
> * an error occurs (including when the property value is not an integer).
> */
> int64_t object_property_get_int(Object *obj, const char *name,
- [PATCH 0/2] qpm: Minor error value corrections, Markus Armbruster, 2020/09/17
- [PATCH 2/2] qom: Correct error values in two contracts, Markus Armbruster, 2020/09/17
- [PATCH 1/2] qom: Clean up object_property_get_enum()'s error value, Markus Armbruster, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, no-reply, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, no-reply, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, Eduardo Habkost, 2020/09/17