[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: move cocoa option to Meson
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] configure: move cocoa option to Meson |
|
Date: |
Wed, 16 Sep 2020 08:30:22 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 9/16/20 1:11 AM, Paolo Bonzini wrote:
> --enable-cocoa)
> - cocoa="yes" ;
> + cocoa="enabled" ;
Lose the stray ; at the same time?
> @@ -101,7 +101,7 @@ if targetos == 'windows'
> elif targetos == 'darwin'
> coref = dependency('appleframeworks', modules: 'CoreFoundation')
> iokit = dependency('appleframeworks', modules: 'IOKit')
> - cocoa = dependency('appleframeworks', modules: 'Cocoa')
> + cocoa = dependency('appleframeworks', modules: 'Cocoa', required:
> get_option('cocoa'))
> hvf = dependency('appleframeworks', modules: 'Hypervisor')
> elif targetos == 'sunos'
> socket = [cc.find_library('socket'),
> @@ -112,6 +112,11 @@ elif targetos == 'haiku'
> cc.find_library('network'),
> cc.find_library('bsd')]
> endif
> +
> +if not cocoa.found() and get_option('cocoa').enabled()
> + error('Cocoa not available on this platform')
> +endif
Isn't the error redundant with the required above?
r~