Re: [PATCH V9 6/6] hw/mips: Add Loongson-3 machine support

[Philippe Mathieu-Daudé]

On 9/16/20 9:56 AM, Philippe Mathieu-Daudé wrote:
> On 9/16/20 4:12 AM, Huacai Chen wrote:
[...]
>> diff --git a/default-configs/mips64el-softmmu.mak 
>> b/default-configs/mips64el-softmmu.mak
>> index 9f8a3ef..26c660a 100644
>> --- a/default-configs/mips64el-softmmu.mak
>> +++ b/default-configs/mips64el-softmmu.mak
>> @@ -3,6 +3,7 @@
>>  include mips-softmmu-common.mak
>>  CONFIG_IDE_VIA=y
>>  CONFIG_FULOONG=y
>> +CONFIG_LOONGSON3V=y
>>  CONFIG_ATI_VGA=y
>>  CONFIG_RTL8139_PCI=y
>>  CONFIG_JAZZ=y
>> diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig
>> index 67d39c5..cc5609b 100644
>> --- a/hw/mips/Kconfig
>> +++ b/hw/mips/Kconfig
>> @@ -45,6 +45,17 @@ config FULOONG
>>      bool
>>      select PCI_BONITO
>>  
>> +config LOONGSON3V
>> +    bool
>> +    select PCKBD
>> +    select SERIAL
>> +    select GOLDFISH_RTC
>> +    select LOONGSON_LIOINTC
>> +    select PCI_EXPRESS_GENERIC_BRIDGE
>> +    select VIRTIO_VGA
>> +    select QXL if SPICE
>> +    select MSI_NONBROKEN

Another error:

../meson.build:577:4: ERROR: Running configure command failed.
The following clauses were found for VIRTIO_VGA
    config VIRTIO_VGA depends on VIRTIO_PCI
    select VIRTIO_VGA if LOONGSON3V
Traceback (most recent call last):
  File "scripts/minikconf.py", line 703, in <module>
    config = data.compute_config()
  File "scripts/minikconf.py", line 253, in compute_config
    clause.process()
  File "scripts/minikconf.py", line 200, in process
    self.dest.set_value(True, self)
  File "scripts/minikconf.py", line 118, in set_value
    raise KconfigDataError('contradiction between clauses when setting
%s' % self)
__main__.KconfigDataError: contradiction between clauses when setting
VIRTIO_VGA

>> +
>>  config MIPS_CPS
>>      bool
>>      select PTIMER