[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 07/12] migration/dirtyrate: Compare page hash results for
From: |
Zheng Chuan |
Subject: |
Re: [PATCH v9 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page |
Date: |
Wed, 16 Sep 2020 11:40:28 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 2020/9/16 0:30, Li Qiang wrote:
> Chuan Zheng <zhengchuan@huawei.com> 于2020年9月15日周二 上午10:34写道:
>>
>> Compare page hash results for recorded sampled page.
>>
>> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
>> Signed-off-by: YanYing Zhuang <ann.zhuangyanying@huawei.com>
>> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>> ---
>> migration/dirtyrate.c | 63
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 63 insertions(+)
>>
>> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
>> index 5e6eedf..2d48eb8 100644
>> --- a/migration/dirtyrate.c
>> +++ b/migration/dirtyrate.c
>> @@ -177,6 +177,69 @@ out:
>> return ret;
>> }
>>
>> +static void calc_page_dirty_rate(struct RamblockDirtyInfo *info)
>> +{
>> + uint32_t crc;
>> + int i;
>> +
>> + for (i = 0; i < info->sample_pages_count; i++) {
>> + crc = get_ramblock_vfn_hash(info, info->sample_page_vfn[i]);
>> + if (crc != info->hash_result[i]) {
>> + info->sample_dirty_count++;
>> + }
>> + }
>> +}
>> +
>> +static struct RamblockDirtyInfo *
>> +find_page_matched(RAMBlock *block, int count,
>> + struct RamblockDirtyInfo *infos)
>> +{
>> + int i;
>> + struct RamblockDirtyInfo *matched;
>> +
>> + for (i = 0; i <= count; i++) {
>
> 'i < count'?
>
Oops, it should be.
Will fix it asap.
>> + if (!strcmp(infos[i].idstr, qemu_ram_get_idstr(block))) {
>> + break;
>> + }
>> + }
>> +
>> + if (i == count) {
>> + return NULL;
>> + }
>> +
>> + if (infos[i].ramblock_addr != qemu_ram_get_host_addr(block) ||
>> + infos[i].ramblock_pages !=
>> + (qemu_ram_get_used_length(block) >> TARGET_PAGE_BITS)) {
>> + return NULL;
>> + }
>> +
>> + matched = &infos[i];
>> +
>> + return matched;
>> +}
>> +
>> +static bool compare_page_hash_info(struct RamblockDirtyInfo *info,
>> + int block_count)
>> +{
>> + struct RamblockDirtyInfo *block_dinfo = NULL;
>> + RAMBlock *block = NULL;
>> +
>> + RAMBLOCK_FOREACH_MIGRATABLE(block) {
>> + block_dinfo = find_page_matched(block, block_count, info);
>> + if (block_dinfo == NULL) {
>> + continue;
>> + }
>> + calc_page_dirty_rate(block_dinfo);
>> + update_dirtyrate_stat(block_dinfo);
>> + }
>> +
>> + if (DirtyStat.total_sample_count == 0) {
>> + return false;
>> + }
>> +
>> + return true;
>> +}
>> +
>> static void calculate_dirtyrate(struct DirtyRateConfig config)
>> {
>> /* todo */
>> --
>> 1.8.3.1
>>
> .
>
- [PATCH v9 00/12] *** A Method for evaluating dirty page rate ***, Chuan Zheng, 2020/09/14
- [PATCH v9 09/12] migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid(), Chuan Zheng, 2020/09/14
- [PATCH v9 01/12] migration/dirtyrate: setup up query-dirtyrate framwork, Chuan Zheng, 2020/09/14
- [PATCH v9 03/12] migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info, Chuan Zheng, 2020/09/14
- [PATCH v9 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page, Chuan Zheng, 2020/09/14
- [PATCH v9 06/12] migration/dirtyrate: Record hash results for each sampled page, Chuan Zheng, 2020/09/14
- [PATCH v9 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status, Chuan Zheng, 2020/09/14
- [PATCH v9 04/12] migration/dirtyrate: Add dirtyrate statistics series functions, Chuan Zheng, 2020/09/14
- [PATCH v9 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE, Chuan Zheng, 2020/09/14
- [PATCH v9 05/12] migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h, Chuan Zheng, 2020/09/14