[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 27/37] qapi/gen.py: Remove unused parameter
From: |
John Snow |
Subject: |
[PATCH 27/37] qapi/gen.py: Remove unused parameter |
Date: |
Tue, 15 Sep 2020 18:40:17 -0400 |
module_basename doesn't use the 'what' argument, so remove it.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/gen.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index c87c84e7c9..e873901672 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -234,7 +234,7 @@ def _is_user_module(name: Optional[str]) -> bool:
def _is_builtin_module(name: Optional[str]) -> bool:
return not name
- def _module_dirname(self, what: str, name: Optional[str]) -> str:
+ def _module_dirname(self, name: Optional[str]) -> str:
if self._is_user_module(name):
return os.path.dirname(name)
return ''
@@ -252,7 +252,7 @@ def _module_basename(self, what: str, name: Optional[str])
-> str:
return ret
def _module_filename(self, what: str, name: Optional[str]) -> str:
- return os.path.join(self._module_dirname(what, name),
+ return os.path.join(self._module_dirname(name),
self._module_basename(what, name))
def _add_module(self, name: Optional[str], blurb: str) -> None:
--
2.26.2
- [PATCH 21/37] qapi/commands.py: enable checking with mypy, (continued)
- [PATCH 21/37] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/15
- [PATCH 16/37] qapi: establish mypy type-checking baseline, John Snow, 2020/09/15
- [PATCH 18/37] qapi/events.py: Move comments into docstrings, John Snow, 2020/09/15
- [PATCH 22/37] qapi/source.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 19/37] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/15
- [PATCH 17/37] qapi/events.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 20/37] qapi/commands.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 23/37] qapi/source.py: delint with pylint, John Snow, 2020/09/15
- [PATCH 28/37] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/09/15
- [PATCH 29/37] qapi/gen.py: delint with pylint, John Snow, 2020/09/15
- [PATCH 27/37] qapi/gen.py: Remove unused parameter,
John Snow <=
- [PATCH 26/37] qapi/gen.py: Enable checking with mypy, John Snow, 2020/09/15
- [PATCH 30/37] qapi/introspect.py: Add a typed 'extra' structure, John Snow, 2020/09/15
- [PATCH 25/37] qapi/gen.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 34/37] qapi/types.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 36/37] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/09/15
- [PATCH 37/37] qapi/visit.py: add notational type hints, John Snow, 2020/09/15
- [PATCH 31/37] qapi/introspect.py: add _gen_features helper, John Snow, 2020/09/15
- [PATCH 32/37] qapi/introspect.py: create a typed 'Node' data structure, John Snow, 2020/09/15
- [PATCH 35/37] qapi/types.py: remove one-letter variables, John Snow, 2020/09/15
- [PATCH 33/37] qapi/introspect.py: add notational type hints, John Snow, 2020/09/15