On 9/14/20 11:27 PM, Paolo Bonzini wrote:
> Looks good. Can you just add a "# Submodules" heading above the test?
>
> I would also like to remove the "yes" value (that is, the default fails if the
> internal copy is not there) but it can be done later for all submodules.
Unless you simply plan to rename {no, yes} to {disabled, enabled}, as for the
Feature objects, why?
That seems to be the only sensible value for --enable-foo, without the =system
or =git specifiers. We *should* fail if no system library nor internal copy is
present.
I suggest remove the
capstone=system option cause the system library may not satisfy the requirements of qemu
and create in-consistence expereince when bug or error happens about capstone. We either have git submodule capstone
or nothing at all
r~