[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/9] migration: stop returning errno from load_snapshot()
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v4 2/9] migration: stop returning errno from load_snapshot() |
Date: |
Tue, 15 Sep 2020 12:35:16 +0100 |
None of the callers care about the errno value since there is a full
Error object populated. This gives consistency with save_snapshot()
which already just returns -1.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
migration/savevm.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/migration/savevm.c b/migration/savevm.c
index 3826c437cc..711137bcbe 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2870,20 +2870,20 @@ int load_snapshot(const char *name, Error **errp)
if (!replay_can_snapshot()) {
error_setg(errp, "Record/replay does not allow loading snapshot "
"right now. Try once more later.");
- return -EINVAL;
+ return -1;
}
if (!bdrv_all_can_snapshot(errp)) {
- return -ENOTSUP;
+ return -1;
}
ret = bdrv_all_find_snapshot(name, errp);
if (ret < 0) {
- return ret;
+ return -1;
}
bs_vm_state = bdrv_all_find_vmstate_bs(errp);
if (!bs_vm_state) {
- return -ENOTSUP;
+ return -1;
}
aio_context = bdrv_get_aio_context(bs_vm_state);
@@ -2892,11 +2892,11 @@ int load_snapshot(const char *name, Error **errp)
ret = bdrv_snapshot_find(bs_vm_state, &sn, name);
aio_context_release(aio_context);
if (ret < 0) {
- return ret;
+ return -1;
} else if (sn.vm_state_size == 0) {
error_setg(errp, "This is a disk-only snapshot. Revert to it "
" offline using qemu-img");
- return -EINVAL;
+ return -1;
}
/* Flush all IO requests so they don't interfere with the new state. */
@@ -2911,7 +2911,6 @@ int load_snapshot(const char *name, Error **errp)
f = qemu_fopen_bdrv(bs_vm_state, 0);
if (!f) {
error_setg(errp, "Could not open VM state file");
- ret = -EINVAL;
goto err_drain;
}
@@ -2927,14 +2926,14 @@ int load_snapshot(const char *name, Error **errp)
if (ret < 0) {
error_setg(errp, "Error %d while loading VM state", ret);
- return ret;
+ return -1;
}
return 0;
err_drain:
bdrv_drain_all_end();
- return ret;
+ return -1;
}
void vmstate_register_ram(MemoryRegion *mr, DeviceState *dev)
--
2.26.2
- [PATCH v4 0/9] migration: bring improved savevm/loadvm/delvm to QMP, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 1/9] block: push error reporting into bdrv_all_*_snapshot functions, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 2/9] migration: stop returning errno from load_snapshot(),
Daniel P . Berrangé <=
- [PATCH v4 3/9] block: add ability to specify list of blockdevs during snapshot, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 4/9] block: allow specifying name of block device for vmstate storage, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 5/9] migration: control whether snapshots are ovewritten, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 6/9] migration: wire up support for snapshot device selection, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 7/9] migration: introduce a delete_snapshot wrapper, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 8/9] iotests: add support for capturing and matching QMP events, Daniel P . Berrangé, 2020/09/15
- [PATCH v4 9/9] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2020/09/15