|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH 05/15] spapr: Get rid of cas_check_pvr() error reporting |
Date: | Tue, 15 Sep 2020 13:03:13 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
14.09.2020 15:34, Greg Kurz wrote:
The cas_check_pvr() function has two purposes: - finding the "best" logical PVR, ie. the most recent one supported by the guest for this CPU type - checking if the guest supports the real PVR of this CPU type, which is just an optional extra information to workaround the lack of support for "compat" mode in PR KVM This logic doesn't need error reporting, really. If we don't find a suitable logical PVR, we return the special value 0 which is definitely not a valid PVR. Let the caller decide on whether it should error out or not.
maybe then rename it s/cas_check_pvr/cas_find_compat_pvr/ or something like this?
This doesn't change the behavior. Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> -- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |