Re: [PATCH v2] tests/qtest/qmp-cmd-test: Use inclusive language

[Claudio Fontana]

It seems to me that "blacklist" is a very commonly used technical term,
and expresses the concept more precisely.

I am not sure what "inclusive language" is or what relationship it has with 
technical work on QEMU.

Thanks,

Claudio

On 9/14/20 6:37 PM, Thomas Huth wrote:
> We simply want to ignore certain queries here, so let's rather
> use the term 'ignore' to express this intention.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Changed naming according to suggestions
> 
>  tests/qtest/qmp-cmd-test.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c
> index 3109a9fe96..8a4c570e83 100644
> --- a/tests/qtest/qmp-cmd-test.c
> +++ b/tests/qtest/qmp-cmd-test.c
> @@ -82,9 +82,9 @@ static void test_query(const void *data)
>      qtest_quit(qts);
>  }
>  
> -static bool query_is_blacklisted(const char *cmd)
> +static bool query_is_ignored(const char *cmd)
>  {
> -    const char *blacklist[] = {
> +    const char *ignored[] = {
>          /* Not actually queries: */
>          "add-fd",
>          /* Success depends on target arch: */
> @@ -101,8 +101,8 @@ static bool query_is_blacklisted(const char *cmd)
>      };
>      int i;
>  
> -    for (i = 0; blacklist[i]; i++) {
> -        if (!strcmp(cmd, blacklist[i])) {
> +    for (i = 0; ignored[i]; i++) {
> +        if (!strcmp(cmd, ignored[i])) {
>              return true;
>          }
>      }
> @@ -179,7 +179,7 @@ static void add_query_tests(QmpSchema *schema)
>              continue;
>          }
>  
> -        if (query_is_blacklisted(si->name)) {
> +        if (query_is_ignored(si->name)) {
>              continue;
>          }
>  
>