Re: [PATCH v5 8/8] qapi: New -compat deprecated-input=crash

[Eric Blake]

On 9/14/20 3:48 AM, Markus Armbruster wrote:
> Policy "crash" calls abort() when deprecated input is received.
>
> Bugs in integration tests may mask the error from policy "reject".
> Provide a larger hammer: crash outright.  Masking that seems unlikely.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---

> +++ b/qemu-options.hx
> @@ -3392,7 +3392,7 @@ DEFHEADING()
>   DEFHEADING(Debug/Expert options:)
>   
>   DEF("compat", HAS_ARG, QEMU_OPTION_compat,
> -    "-compat 
> [deprecated-input=accept|reject][,deprecated-output=accept|hide]\n"
> +    "-compat 
> [deprecated-input=accept|reject|crash][,deprecated-output=accept|hide]\n"
>       "                Policy for handling deprecated management interfaces\n",
>       QEMU_ARCH_ALL)
>   SRST
> @@ -3403,6 +3403,8 @@ SRST
>           Accept deprecated commands and arguments
>       ``deprecated-input=reject``
>           Reject deprecated commands and arguments
> +    ``deprecated-input=crash``
> +        Crash on deprecated command

Missing 'and arguments'?

Otherwise,
Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org