[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine co
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v5 3/8] qapi: Restrict balloon-related commands to machine code |
|
Date: |
Mon, 14 Sep 2020 11:48:53 +0200 |
> Am 14.09.2020 um 11:42 schrieb Philippe Mathieu-Daudé <philmd@redhat.com>:
>
> +Laurent and David
>
>> On 9/14/20 11:16 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé <philmd@redhat.com> writes:
>>
>>> Only qemu-system-FOO and qemu-storage-daemon provide QMP
>>> monitors, therefore such declarations and definitions are
>>> irrelevant for user-mode emulation.
>>>
>>> Restricting the balloon-related commands to machine.json
>>> allows pulling less declarations/definitions to user-mode.
>>
>> How this affects user mode is not obvious to (ignorant) me. Can you
>> provide a clue?
>
> I guess this was discussed with David at some point.
>
> Maybe the QMP commands are not exposed via HMP, making this
> code unreachable?
>
> Anyhow user-mode binaries don't use the memory ballooning feature,
> this is specific to system-mode emulation.
>
> Laurent/David, do you have some more trivial explanation?
Agreed.
No memory ballooning device -> no memory ballooning :)
>
> Thanks,
>
> Phil.
>
[PATCH v5 4/8] qapi: Restrict query-vm-generation-id command to machine code, Philippe Mathieu-Daudé, 2020/09/13
[PATCH v5 5/8] qapi: Restrict query-uuid command to machine code, Philippe Mathieu-Daudé, 2020/09/13
[PATCH v5 6/8] qapi: Restrict device memory commands to machine code, Philippe Mathieu-Daudé, 2020/09/13
[PATCH v5 7/8] qapi: Extract ACPI commands to 'acpi.json', Philippe Mathieu-Daudé, 2020/09/13
[PATCH v5 8/8] qapi: Extract PCI commands to 'pci.json', Philippe Mathieu-Daudé, 2020/09/13
Re: [PATCH v5 0/8] user-mode: Prune build dependencies (part 2), Markus Armbruster, 2020/09/15