Re: [PATCH] lockable.h: always define unknown_lock_type

[Richard Henderson]

On 9/13/20 6:42 PM, mingli.yu@windriver.com wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> There comes below build failure when use gcc 10.1.0 and
> "-Og" passed to compiler.
>  | 
> /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: 
> /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:25:
>  undefined reference to `unknown_lock_type'
>  | 
> /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: 
> ../fsdev/qemu-fsdev-throttle.o: in function `fsdev_co_throttle_request':
>  | 
> /mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:103:
>  undefined reference to `unknown_lock_type'
>  | 
> /usr/lib/gcc/x86_64-wrs-linux/10.1.0/../../../../x86_64-wrs-linux/bin/ld.bfd: 
> ../fsdev/qemu-fsdev-throttle.o:/mnt/build/tmp/work/x86_64-linux/qemu-system-native/5.1.0-r0/qemu-5.1.0/fsdev/qemu-fsdev-throttle.c:103:
>  more undefined references to `unknown_lock_type' follow
>  | collect2: error: ld returned 1 exit status
> 
> So always define unknown_lock_type to fix the above error.

There's a lot that won't work with -Og, including stuff that uses
qemu_build_not_reached (which this itself should have been using).


r~