[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v8 27/27] Revert "configure: add --ninja option"

From: Paolo Bonzini
Subject: Re: [PATCH v8 27/27] Revert "configure: add --ninja option"
Date: Sun, 13 Sep 2020 18:12:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 13/09/20 18:03, 罗勇刚(Yonggang Luo) wrote:
> _WIN32 are more precise and only depends on the compiler, on the
> other hand, CONFIG_POSIX  and  CONFIG_WIN32  need configure
> scripts. I prefer  _WIN32  unless the compiler can not provide enough
> information.

That's not what the QEMU coding standards say; we generally don't test
the preprocessor symbols.  If we were to change to _WIN32, it should be
done at once on the whole codebase (don't do it :)).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]