[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2)
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2) |
|
Date: |
Sun, 13 Sep 2020 15:40:09 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 13/09/20 13:31, Philippe Mathieu-Daudé wrote:
>> I'm not sure about the first. It's a bit ugly to have a property whose
>> getter aborts.
> This is (IIUC) the change Markus requested in v3 (see [*]).
>
> Commit description: "add a stub to satisfy the linker."
>
> This stub should be never used on user-mode => abort.
>
> [*] https://www.mail-archive.com/qemu-block@nongnu.org/msg67560.html
>
Yes, I'm not sure about the stub _in general_. I would prefer to either
have the type available even on user-mode emulation, or remove the
property altogether... I don't know, anything but not a property that
aborts. :)
Paolo
- [PATCH v4 3/9] qapi: Correct balloon documentation, (continued)
- [PATCH v4 3/9] qapi: Correct balloon documentation, Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 4/9] qapi: Restrict balloon-related commands to machine code, Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 5/9] qapi: Restrict query-vm-generation-id command to machine code, Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 6/9] qapi: Restrict query-uuid command to machine code, Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 7/9] qapi: Restrict device memory commands to machine code, Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 8/9] qapi: Extract ACPI commands to 'acpi.json', Philippe Mathieu-Daudé, 2020/09/10
- [PATCH v4 9/9] qapi: Extract PCI commands to 'pci.json', Philippe Mathieu-Daudé, 2020/09/10
- Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2), no-reply, 2020/09/10
- Re: [PATCH v4 0/9] user-mode: Prune build dependencies (part 2), Paolo Bonzini, 2020/09/12