[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles
From: |
Max Reitz |
Subject: |
Re: [PULL v2 01/46] qemu-iotests: move check-block back to Makefiles |
Date: |
Fri, 11 Sep 2020 13:05:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 11.09.20 12:58, Max Reitz wrote:
> On 06.09.20 19:53, Paolo Bonzini wrote:
>> check-block has its own test harness, unlike every other test. If
>> we capture its output, as is in general nicer to do without V=1,
>> there will be no sign of progress. So for lack of a better option
>> just move the invocation of the test back to Makefile rules.
>>
>> As a side effect, this will also fix "make check" in --disable-tools
>> builds, as they were trying to run qemu-iotests without having
>> made qemu-img before.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> meson.build | 1 -
>> tests/Makefile.include | 15 ++++++++++++---
>> tests/qemu-iotests/meson.build | 4 ----
>> 3 files changed, 12 insertions(+), 8 deletions(-)
>
> I’m not entirely sure why (or I would’ve sent a patch myself)
On closer inspection it seems like it’s because of the
“build_by_default: false”, which seems like a rather conscious decision.
Was I only lucky that the socket_scm_helper was built by default so
far? Should I have explicitly built it all this time?
Max
signature.asc
Description: OpenPGP digital signature