Re: [PATCH 15/29] block/export: Add node-name to BlockExportOptions

[Max Reitz]

On 07.09.20 20:19, Kevin Wolf wrote:
> Every block export needs a block node to export, so add a 'node-name'
> option to BlockExportOptions and remove the replaced option 'device'
> from BlockExportOptionsNbd.
> 
> To maintain compatibility in nbd-server-add, BlockExportOptionsNbd needs
> to be wrapped by a new type NbdServerAddOptions that adds 'device' back
> because nbd-server-add doesn't use the BlockExportOptions base type at
> all (so even without changing it to a 'node-name' option in
> block-export-add, this compatibility code would be necessary).
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi/block-export.json         | 27 ++++++++++++++++-----
>  block/monitor/block-hmp-cmds.c |  6 ++---
>  blockdev-nbd.c                 | 44 +++++++++++++++++++++++++---------
>  qemu-nbd.c                     |  2 +-
>  4 files changed, 58 insertions(+), 21 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>

signature.asc
Description: OpenPGP digital signature