Re: [PATCH 04/29] block/export: Add BlockExport infrastructure and block-export-add

[Max Reitz]

On 07.09.20 20:19, Kevin Wolf wrote:
> We want to have a common set of commands for all types of block exports.
> Currently, this is only NBD, but we're going to add more types.
> 
> This patch adds the basic BlockExport and BlockExportDriver structs and
> a QMP command block-export-add that creates a new export based on the
> given BlockExportOptions.
> 
> qmp_nbd_server_add() becomes a wrapper around qmp_block_export_add().
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  qapi/block-export.json   |  9 ++++++++
>  include/block/export.h   | 33 +++++++++++++++++++++++++++
>  include/block/nbd.h      |  5 ++++-
>  block/export/export.c    | 48 ++++++++++++++++++++++++++++++++++++++++
>  blockdev-nbd.c           | 28 +++++++++++++++++------
>  nbd/server.c             | 15 ++++++++++++-
>  block/export/meson.build |  1 +
>  block/meson.build        |  2 ++
>  meson.build              |  2 +-
>  9 files changed, 133 insertions(+), 10 deletions(-)
>  create mode 100644 include/block/export.h
>  create mode 100644 block/export/export.c
>  create mode 100644 block/export/meson.build

Reviewed-by: Max Reitz <mreitz@redhat.com>

signature.asc
Description: OpenPGP digital signature