Re: [PATCH v3 09/15] replay: implement replay-seek command

[Pavel Dovgalyuk]

On 07.09.2020 15:45, Alex Bennée wrote:
> Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru> writes:
>
> > From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
> >
> > This patch adds hmp/qmp commands replay_seek/replay-seek that proceed
> > the execution to the specified instruction count.
> > The command automatically loads nearest snapshot and replays the execution
> > to find the desired instruction count.
> >
> > Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> > Acked-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >   hmp-commands.hx           |   18 +++++++++
> >   include/monitor/hmp.h     |    1
> >   qapi/replay.json          |   20 ++++++++++
> >   replay/replay-debugging.c |   92 +++++++++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 131 insertions(+)
> >
> > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > index e8ce385879..4288274c4e 100644
> > --- a/hmp-commands.hx
> > +++ b/hmp-commands.hx
> > @@ -1851,6 +1851,24 @@ SRST
> >     The command is ignored when there are no replay breakpoints.
> >   ERST
> >   
> > +    {
> > +        .name       = "replay_seek",
> > +        .args_type  = "icount:i",
> > +        .params     = "icount",
> > +        .help       = "replay execution to the specified instruction count",
> > +        .cmd        = hmp_replay_seek,
> > +    },
> > +
> > +SRST
> > +``replay_seek`` *icount*
> > +Automatically proceed to the instruction count *icount*, when
> > +replaying the execution. The command automatically loads nearest
> > +snapshot and replays the execution to find the desired instruction.
> > +When there is no preceding snapshot or the execution is not replayed,
> > +then the command fails.
> > +*icount* for the reference may be observed with ``info replay`` command.
> > +ERST
> > +
> >       {
> >           .name       = "info",
> >           .args_type  = "item:s?",
>
>
> This seems to break the build:
>
>    Warning, treated as error:
>    /home/alex/lsrc/qemu.git/docs/../hmp-commands.hx:1863:Definition list ends 
> without a blank line; unexpected unindent.

Thanks, I've added an indent.


Pavel Dovgalyuk