[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/12] hw/riscv: Drop CONFIG_SIFIVE
|
From: |
Alistair Francis |
|
Subject: |
Re: [PATCH 11/12] hw/riscv: Drop CONFIG_SIFIVE |
|
Date: |
Fri, 4 Sep 2020 10:42:40 -0700 |
On Thu, Sep 3, 2020 at 3:49 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> The name SIFIVE is too vague to convey the required component of
> MSI_NONBROKEN. Let's drop the option, and select MSI_NONBROKEN in
> each machine instead.
>
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
>
> hw/riscv/Kconfig | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig
> index 7d017bc..e152fdc 100644
> --- a/hw/riscv/Kconfig
> +++ b/hw/riscv/Kconfig
> @@ -1,13 +1,9 @@
> config IBEX
> bool
>
> -config SIFIVE
> - bool
> - select MSI_NONBROKEN
> -
> config SIFIVE_E
> bool
> - select SIFIVE
> + select MSI_NONBROKEN
> select SIFIVE_CLINT
> select SIFIVE_GPIO
> select SIFIVE_PLIC
> @@ -18,7 +14,7 @@ config SIFIVE_E
> config SIFIVE_U
> bool
> select CADENCE
> - select SIFIVE
> + select MSI_NONBROKEN
> select SIFIVE_CLINT
> select SIFIVE_GPIO
> select SIFIVE_PDMA
> @@ -31,7 +27,7 @@ config SIFIVE_U
> config SPIKE
> bool
> select HTIF
> - select SIFIVE
> + select MSI_NONBROKEN
> select SIFIVE_CLINT
> select SIFIVE_PLIC
>
> @@ -44,20 +40,20 @@ config RISCV_VIRT
> bool
> imply PCI_DEVICES
> imply TEST_DEVICES
> + select MSI_NONBROKEN
> select PCI
> select SERIAL
> select GOLDFISH_RTC
> select VIRTIO_MMIO
> select PCI_EXPRESS_GENERIC_BRIDGE
> select PFLASH_CFI01
> - select SIFIVE
> select SIFIVE_CLINT
> select SIFIVE_PLIC
> select SIFIVE_TEST
>
> config MICROCHIP_PFSOC
> bool
> - select SIFIVE
> + select MSI_NONBROKEN
> select SIFIVE_CLINT
> select UNIMP
> select MCHP_PFSOC_MMUART
> --
> 2.7.4
>
>
- Re: [PATCH 05/12] hw/riscv: Move sifive_clint model to hw/intc, (continued)
- [PATCH 07/12] hw/riscv: Move riscv_htif model to hw/char, Bin Meng, 2020/09/03
- [PATCH 08/12] hw/riscv: Move sifive_uart model to hw/char, Bin Meng, 2020/09/03
- [PATCH 09/12] hw/riscv: Move sifive_test model to hw/misc, Bin Meng, 2020/09/03
- [PATCH 10/12] hw/riscv: Always build riscv_hart.c, Bin Meng, 2020/09/03
- [PATCH 11/12] hw/riscv: Drop CONFIG_SIFIVE, Bin Meng, 2020/09/03
- Re: [PATCH 11/12] hw/riscv: Drop CONFIG_SIFIVE,
Alistair Francis <=
- [PATCH 12/12] hw/riscv: Sort the Kconfig options in alphabetical order, Bin Meng, 2020/09/03
- Re: [PATCH 00/12] hw/riscv: Clean up the directory, Peter Maydell, 2020/09/03
- Re: [PATCH 00/12] hw/riscv: Clean up the directory, Alistair Francis, 2020/09/06