[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 06/13] dma: Let dma_memory_read() propagate MemTxResult
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 06/13] dma: Let dma_memory_read() propagate MemTxResult |
Date: |
Fri, 4 Sep 2020 17:44:32 +0200 |
dma_memory_rw_relaxed() returns a MemTxResult type.
Do not discard it, return it to the caller.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/sysemu/dma.h | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
index 661d7d0ca88..2961a96ad67 100644
--- a/include/sysemu/dma.h
+++ b/include/sysemu/dma.h
@@ -89,8 +89,9 @@ static inline MemTxResult dma_memory_rw_relaxed(AddressSpace
*as,
buf, len, dir == DMA_DIRECTION_FROM_DEVICE);
}
-static inline int dma_memory_read_relaxed(AddressSpace *as, dma_addr_t addr,
- void *buf, dma_addr_t len)
+static inline MemTxResult dma_memory_read_relaxed(AddressSpace *as,
+ dma_addr_t addr,
+ void *buf, dma_addr_t len)
{
return dma_memory_rw_relaxed(as, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
}
@@ -124,8 +125,20 @@ static inline MemTxResult dma_memory_rw(AddressSpace *as,
dma_addr_t addr,
return dma_memory_rw_relaxed(as, addr, buf, len, dir);
}
-static inline int dma_memory_read(AddressSpace *as, dma_addr_t addr,
- void *buf, dma_addr_t len)
+/**
+ * dma_memory_read: Read from an address space from DMA controller.
+ *
+ * Return a MemTxResult indicating whether the operation succeeded
+ * or failed (eg unassigned memory, device rejected the transaction,
+ * IOMMU fault). Called within RCU critical section.
+ *
+ * @as: #AddressSpace to be accessed
+ * @addr: address within that address space
+ * @buf: buffer with the data transferred
+ * @len: length of the data transferred
+ */
+static inline MemTxResult dma_memory_read(AddressSpace *as, dma_addr_t addr,
+ void *buf, dma_addr_t len)
{
return dma_memory_rw(as, addr, buf, len, DMA_DIRECTION_TO_DEVICE);
}
--
2.26.2
- Re: [PATCH 02/13] docs/devel/loads-stores: Add regexp for DMA functions, (continued)
- [PATCH 03/13] dma: Document address_space_map/address_space_unmap() prototypes, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 04/13] dma: Let dma_memory_set() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 05/13] dma: Let dma_memory_rw() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 06/13] dma: Let dma_memory_read() propagate MemTxResult,
Philippe Mathieu-Daudé <=
- [PATCH 07/13] dma: Let dma_memory_write() propagate MemTxResult, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 08/13] dma: Let dma_memory_valid() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/09/04
- [PATCH 09/13] dma: Let dma_memory_set() take MemTxAttrs argument, Philippe Mathieu-Daudé, 2020/09/04