qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] hw/core: Move hw_error() out of cpus.c


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/2] hw/core: Move hw_error() out of cpus.c
Date: Wed, 2 Sep 2020 17:59:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/2/20 5:38 PM, Richard Henderson wrote:
> On 9/1/20 11:37 PM, Thomas Huth wrote:
>> - Move the function as "static inline" into the header file
>>   instead - it's not so big, so an inline function should be
>>   ok here.
> 
> stdarg and inline do not mix.
> 
>> - Add a big fat warning comment to the header that this
>>   function should not be used for new code anymore.
> 
> But certainly this.

Will do, but this has been proven to not work well...

> 
> 
> r~
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]