[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 35/43] blockdev: Fix active commit choice
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v8 35/43] blockdev: Fix active commit choice |
Date: |
Wed, 2 Sep 2020 11:10:28 +0200 |
Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
> We have to perform an active commit whenever the top node has a parent
> that has taken the WRITE permission on it.
>
> This means that block-commit's @backing-file parameter is longer allowed
s/longer/no longer/
> for such nodes, and that users will have to issue a block-job-complete
> command. Neither should pose a problem in practice, because this case
> was basically just broken until now.
>
> (Since this commit already touches block-commit's documentation, it also
> moves up the chunk explaining general block-commit behavior that for
> some reason was situated under @backing-file.)
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Kevin
- [PATCH v8 27/43] block: Use child access functions for QAPI queries, (continued)
- [PATCH v8 27/43] block: Use child access functions for QAPI queries, Max Reitz, 2020/09/01
- [PATCH v8 28/43] block-copy: Use CAF to find sync=top base, Max Reitz, 2020/09/01
- [PATCH v8 29/43] mirror: Deal with filters, Max Reitz, 2020/09/01
- [PATCH v8 30/43] backup: Deal with filters, Max Reitz, 2020/09/01
- [PATCH v8 31/43] commit: Deal with filters, Max Reitz, 2020/09/01
- [PATCH v8 32/43] nbd: Use CAF when looking for dirty bitmap, Max Reitz, 2020/09/01
- [PATCH v8 33/43] qemu-img: Use child access functions, Max Reitz, 2020/09/01
- [PATCH v8 35/43] blockdev: Fix active commit choice, Max Reitz, 2020/09/01
- Re: [PATCH v8 35/43] blockdev: Fix active commit choice,
Kevin Wolf <=
- [PATCH v8 34/43] block: Drop backing_bs(), Max Reitz, 2020/09/01
- [PATCH v8 36/43] block: Inline bdrv_co_block_status_from_*(), Max Reitz, 2020/09/01
- [PATCH v8 38/43] iotests: Test that qcow2's data-file is flushed, Max Reitz, 2020/09/01
- [PATCH v8 37/43] block: Leave BDS.backing_{file,format} constant, Max Reitz, 2020/09/01
- [PATCH v8 39/43] iotests: Let complete_and_wait() work with commit, Max Reitz, 2020/09/01
- [PATCH v8 40/43] iotests: Add filter commit test cases, Max Reitz, 2020/09/01
- [PATCH v8 41/43] iotests: Add filter mirror test cases, Max Reitz, 2020/09/01
- [PATCH v8 43/43] iotests: Test committing to overridden backing, Max Reitz, 2020/09/01
- [PATCH v8 42/43] iotests: Add test for commit in sub directory, Max Reitz, 2020/09/01
- Re: [PATCH v8 00/43] block: Deal with filters, Kevin Wolf, 2020/09/02