[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 07/10] migration/colo: Plug memleaks in colo_process_incoming_
From: |
Pan Nengyuan |
Subject: |
[PATCH v2 07/10] migration/colo: Plug memleaks in colo_process_incoming_thread |
Date: |
Mon, 31 Aug 2020 09:43:12 -0400 |
'local_err' forgot to free in colo_process_incoming_thread error path.
Fix that.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
---
Cc: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
---
- V2: Arrange all 'error_report_err' in 'out' label(suggested by Li Qiang).
---
migration/colo.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration/colo.c b/migration/colo.c
index ea7d1e9d4e..2288188fe2 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -888,7 +888,6 @@ void *colo_process_incoming_thread(void *opaque)
while (mis->state == MIGRATION_STATUS_COLO) {
colo_wait_handle_message(mis, fb, bioc, &local_err);
if (local_err) {
- error_report_err(local_err);
break;
}
@@ -924,6 +923,10 @@ out:
qemu_fclose(fb);
}
+ if (local_err) {
+ error_report_err(local_err);
+ }
+
/* Hope this not to be too long to loop here */
qemu_sem_wait(&mis->colo_incoming_sem);
qemu_sem_destroy(&mis->colo_incoming_sem);
--
2.18.2
- [PATCH v2 00/10] fix some error memleaks, Pan Nengyuan, 2020/08/31
- [PATCH v2 01/10] qga/channel-posix: Plug memory leak in ga_channel_write_all(), Pan Nengyuan, 2020/08/31
- [PATCH v2 04/10] target/i386/sev: Plug memleak in sev_read_file_base64, Pan Nengyuan, 2020/08/31
- [PATCH v2 07/10] migration/colo: Plug memleaks in colo_process_incoming_thread,
Pan Nengyuan <=
- [PATCH v2 03/10] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Pan Nengyuan, 2020/08/31
- [PATCH v2 06/10] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Pan Nengyuan, 2020/08/31
- [PATCH v2 09/10] block/file-posix: fix a possible undefined behavior, Pan Nengyuan, 2020/08/31
- [PATCH v2 08/10] blockdev: Fix a memleak in drive_backup_prepare(), Pan Nengyuan, 2020/08/31
- [PATCH v2 10/10] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string, Pan Nengyuan, 2020/08/31
- [PATCH v2 02/10] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init, Pan Nengyuan, 2020/08/31
- [PATCH v2 05/10] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context(), Pan Nengyuan, 2020/08/31