[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subcla
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subclasses |
|
Date: |
Fri, 28 Aug 2020 14:44:48 +0100 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Aug 12, 2020 at 08:25:35PM -0700, Richard Henderson wrote:
> We had a second set of function pointers in QCryptoCipherBuiltin,
> which are redundant with QCryptoCipherDriver. Split the AES and
> DES implementations to avoid one level of indirection.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> crypto/cipher-builtin.inc.c | 553 +++++++++++++++---------------------
> 1 file changed, 227 insertions(+), 326 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 11/17] crypto/builtin: Remove odd-sized AES block handling, (continued)
- [PATCH 12/17] crypto/builtin: Merge qcrypto_cipher_aes_{ecb, xts}_{en, de}crypt, Richard Henderson, 2020/08/12
- [PATCH 13/17] crypto/builtin: Move AES_cbc_encrypt into cipher-builtin.inc.c, Richard Henderson, 2020/08/12
- [PATCH 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc, Richard Henderson, 2020/08/12
- [PATCH 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subclasses, Richard Henderson, 2020/08/12
- Re: [PATCH 15/17] crypto/builtin: Split QCryptoCipherBuiltin into subclasses,
Daniel P . Berrangé <=
- [PATCH 17/17] crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses, Richard Henderson, 2020/08/12
- [PATCH 16/17] crypto/nettle: Split QCryptoCipherNettle into subclasses, Richard Henderson, 2020/08/12
- Re: [PATCH 00/17] crypto/cipher: Class hierarchy cleanups, Philippe Mathieu-Daudé, 2020/08/13
- Re: [PATCH 00/17] crypto/cipher: Class hierarchy cleanups, no-reply, 2020/08/13
- Re: [PATCH 00/17] crypto/cipher: Class hierarchy cleanups, no-reply, 2020/08/13
- Re: [PATCH 00/17] crypto/cipher: Class hierarchy cleanups, Daniel P . Berrangé, 2020/08/17