Re: [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7

[no-reply]

Patchew URL: 20200824130114.41368-1-thuth@redhat.com/">https://patchew.org/QEMU/20200824130114.41368-1-thuth@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20200824130114.41368-1-thuth@redhat.com
Subject: [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200824130114.41368-1-thuth@redhat.com -> 
patchew/20200824130114.41368-1-thuth@redhat.com
Switched to a new branch 'test'
eb8ed63 disas/libvixl: Fix fall-through annotation for GCC >= 7

=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#46: FILE: disas/libvixl/vixl/globals.h:111:
+// Fallthrough annotation for Clang and C++11(201103L).

ERROR: do not use C99 // comments
#49: FILE: disas/libvixl/vixl/globals.h:114:
+// Fallthrough annotation for GCC >= 7.

total: 2 errors, 0 warnings, 24 lines checked

Commit eb8ed63c0cc3 (disas/libvixl: Fix fall-through annotation for GCC >= 7) 
has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200824130114.41368-1-thuth@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200824130114.41368-1-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com