[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in vir
From: |
Li Qiang |
Subject: |
Re: [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check() |
Date: |
Wed, 26 Aug 2020 09:35:35 +0800 |
Chen Qun <kuhn.chenqun@huawei.com> 于2020年8月25日周二 下午7:32写道:
>
> Clang static code analyzer show warning:
> hw/net/virtio-net.c:2077:5: warning: Value stored to 'tcp_flag' is never read
> tcp_flag &= VIRTIO_NET_TCP_FLAG;
> ^ ~~~~~~~~~~~~~~~~~~~
>
> The 'VIRTIO_NET_TCP_FLAG' is '0x3F'. The last ‘tcp_flag’ assignment statement
> is
> the same as that of the first two statements.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> ---
> hw/net/virtio-net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index a1fe9e9285..cb0d27084c 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -2075,7 +2075,6 @@ static int
> virtio_net_rsc_tcp_ctrl_check(VirtioNetRscChain *chain,
> tcp_flag = htons(tcp->th_offset_flags);
> tcp_hdr = (tcp_flag & VIRTIO_NET_TCP_HDR_LENGTH) >> 10;
> tcp_flag &= VIRTIO_NET_TCP_FLAG;
> - tcp_flag = htons(tcp->th_offset_flags) & 0x3F;
> if (tcp_flag & TH_SYN) {
> chain->stat.tcp_syn++;
> return RSC_BYPASS;
> --
> 2.23.0
>
>
- Re: [PATCH v2 01/10] hw/arm/virt-acpi-build:Remove dead assignment in build_madt(), (continued)
- [PATCH v2 03/10] target/arm/translate-a64:Remove dead assignment in handle_scalar_simd_shli(), Chen Qun, 2020/08/25
- [PATCH v2 02/10] hw/arm/omap1:Remove redundant statement in omap_clkdsp_read(), Chen Qun, 2020/08/25
- [PATCH v2 04/10] target/arm/translate-a64:Remove redundant statement in disas_simd_two_reg_misc_fp16(), Chen Qun, 2020/08/25
- [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(), Chen Qun, 2020/08/25
- Re: [PATCH v2 06/10] hw/net/virtio-net:Remove redundant statement in virtio_net_rsc_tcp_ctrl_check(),
Li Qiang <=
- [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), Chen Qun, 2020/08/25
- [PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Chen Qun, 2020/08/25
- [PATCH v2 09/10] hw/intc: Remove redundant statement in exynos4210_combiner_read(), Chen Qun, 2020/08/25