Re: [PULL] nvme updates

[Peter Maydell]

On Tue, 25 Aug 2020 at 21:12, Keith Busch <kbusch@kernel.org> wrote:
>
> On Sun, Aug 23, 2020 at 02:56:12PM +0100, Peter Maydell wrote:
> > Hi; it looks like this isn't a gpg-signed tag?
> >
> > error: remotes/nvme/nvme-next: cannot verify a non-tag object of type 
> > commit.
>
> Oops, sorry I forgot about that part of the procedure here. The repo should
> have a signed tag now:

Thanks; the gpg key setup looks ok.

I notice that all the commits in the repo have Klaus's signed-off-by.
Usually the expectation is that the person who sends the pull req
is the one who's curated the tree and added their signed-off-by,
but are you doing a jointly-administered tree here ?

The build has a format string issue that shows up on OSX, Windows,
and 32-bit builds:

In file included from ../../hw/block/trace.h:1:0,
                 from ../../hw/block/fdc.c:48:
./trace/trace-hw_block.h: In function '_nocheck__trace_pci_nvme_err_mdts':
./trace/trace-hw_block.h:2162:18: error: format '%llu' expects
argument of type 'long long unsigned int', but argument 6 has type
'size_t {aka unsigned int}' [-Werror=format=]
         qemu_log("%d@%zu.%06zu:pci_nvme_err_mdts " "cid %"PRIu16" len
%"PRIu64"" "\n",
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

thanks
-- PMM