Re: [RFC v3 1/1] memory: Skip bad range assertion if notifier supports arbitrary masks

[Peter Xu]

On Wed, Aug 19, 2020 at 03:15:26PM +0800, Jason Wang wrote:
> Yes, actually, I feel confused after reading the codes. Is notifier->start
> IOVA or GPA?
> 
> In vfio.c, we did:
> 
>         iommu_notifier_init(&giommu->n, vfio_iommu_map_notify,
>                             IOMMU_NOTIFIER_ALL,
>                             section->offset_within_region,
>                             int128_get64(llend),
>                             iommu_idx);
> 
> So it looks to me the start and end are GPA, but the assertion above check
> it against IOVA which seems to be wrong ....

It should be iova; both section->offset_within_region and llend are for the
device's iova address space.  Thanks,

-- 
Peter Xu