Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()

From:	Kevin Wolf
Subject:	Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()
Date:	Mon, 17 Aug 2020 11:41:09 +0200

Am 14.08.2020 um 18:02 hat Pan Nengyuan geschrieben:
> 'local_err' seems forgot to propagate in error path, it'll cause
> a memleak. Fix it.
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>

I wonder if using ERRP_GUARD() wouldn't simplify this. Anyway, the fix
looks correct:

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 03/12] elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init, (continued)
- [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64, Pan Nengyuan, 2020/08/14
  - Re: [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64, Li Qiang, 2020/08/26
- [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all(), Pan Nengyuan, 2020/08/14
  - Re: [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all(), Li Qiang, 2020/08/26
- [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context(), Pan Nengyuan, 2020/08/14
  - Re: [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context(), Li Qiang, 2020/08/26
- [PATCH 08/12] migration/colo: Plug memleaks in colo_process_incoming_thread, Pan Nengyuan, 2020/08/14
- [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare(), Pan Nengyuan, 2020/08/14
  - Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare(), Kevin Wolf <=
  - Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare(), Li Qiang, 2020/08/26
- [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Pan Nengyuan, 2020/08/14
  - Re: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Li Qiang, 2020/08/26
- [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Pan Nengyuan, 2020/08/14
  - Re: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Viktor Prutyanov, 2020/08/23
  - Re: [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Li Qiang, 2020/08/26
- [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Pan Nengyuan, 2020/08/14
  - Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Pierre Morel, 2020/08/14
  - Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Cornelia Huck, 2020/08/17
  - Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Li Qiang, 2020/08/26

Prev by Date: Re: [PATCH 10/12] block/file-posix: fix a possible undefined behavior
Next by Date: Re: [PATCH v3 00/12] preallocate filter
Previous by thread: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()
Next by thread: Re: [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare()
Index(es):
- Date
- Thread